ci: temp hack: update windows chrome/chromedriver #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These windows CI failures are becoming annoying. I looked at various options to update chrome/chromedriver in a Windows image-runner in a throw-away Github repo and found one that seems to work.
From a tip on the chromedriver usergroup.
And let's see if --no-sandbox is needed for linux or macos
Review current usages see if we can delete for our tests. Before increasing ci testing scope rerun api tests without debug logging.
|
Ok, this is a mess of explorations, rather than rebasing, I'll close this PR and create a fresh one with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These windows CI failures are becoming annoying.
I looked at various options to update chrome/chromedriver in a Windows image-runner in a throw-away Github repo and found one that seems to work.
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions
I have updated CHANGELOG.adoc with a description of the addressed issue.