Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): v5 extra cleanups #2169

Merged
merged 16 commits into from
Nov 22, 2023
Merged

chore(repo): v5 extra cleanups #2169

merged 16 commits into from
Nov 22, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Nov 20, 2023

Description

Breaking Changes:

  • Drop isLegacyFrontendApiKey from @clerk/shared
  • Drop default exports from @clerk/clerk-js
    • on headless Clerk type
    • on ui and ui.retheme Portal
  • Use isProductionFromSecretKey instead of isProductionFromApiKey
  • Use isDevelopmentFromSecretKey instead of isDevelopmentFromApiKey

Changes:

  • Rename HeadlessBrowserClerkConstrutor / HeadlessBrowserClerkConstructor (typo)
  • Use isomorphicAtob / isomorhpicBtoa to replace base-64 in @clerk/expo
  • Refactor merging build-time and runtime props in @clerk/backend clerk client
  • Drop node-fetch dependency from @clerk/backend
  • Drop duplicate test in @clerk/backend

Review it per commit!

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Nov 20, 2023
Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: f97742f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/clerk-js Major
@clerk/shared Major
@clerk/clerk-sdk-node Minor
@clerk/backend Minor
@clerk/nextjs Minor
@clerk/clerk-react Minor
@clerk/clerk-expo Minor
@clerk/chrome-extension Patch
@clerk/fastify Patch
@clerk/remix Patch
gatsby-plugin-clerk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl changed the title Sdk 782 extra cleanup chore(repo): Extra v5 cleanups Nov 20, 2023
@dimkl dimkl changed the title chore(repo): Extra v5 cleanups chore(repo): v5 extra cleanups Nov 20, 2023
Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimkl 👏🏻

@dimkl dimkl added this pull request to the merge queue Nov 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2023
@dimkl dimkl force-pushed the sdk-782-extra-cleanup branch 2 times, most recently from e988adc to 83fc9ff Compare November 21, 2023 16:33
@dimkl dimkl added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 4bb5705 Nov 22, 2023
7 checks passed
@dimkl dimkl deleted the sdk-782-extra-cleanup branch November 22, 2023 10:16
desiprisg pushed a commit that referenced this pull request Nov 23, 2023
* chore(clerk-expo): Use isomorphicAtob/isomorhpicBtoa to drop base-64 dep

* chore(clerk-sdk-node): Add comment and drop todo in interstitial response errors

* fix(clerk-react): Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` typo

* fix(clerk-react): Drop unused import

* chore(backend): Refactor merging of props in request/factory

* chore(clerk-react,nextjs): Update JSDoc examples with `withServerSideAuth`

* chore(shared): Drop `isLegacyFrontendApiKey`

* chore(clerk-js): Drop forgotten default exports

* chore(clerk-js): Drop node-fetch dependency

* chore(backend): Duplicate test

* chore(remix): Rename `noSecretKeyOrApiKeyError` to `noSecretKeyError`

* chore(clerk-sdk-node): Re-use `isDevelopmentFromApiKey` from `@clerk/shared`

* chore(backend): Drop unused `LoadResourcesOptions` export

* chore(*): Rename `isDevelopmentFromApiKey` to `isDevelopmentFromSecretKey`

* chore(*): Rename `isProductionFromApiKey` to `isProductionFromSecretKey`

* chore(repo): Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants