Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integration): Improve Playwright logging #2243

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Conversation

LekoArts
Copy link
Member

@LekoArts LekoArts commented Dec 1, 2023

Description

Improvements to the output you see when running our integration tests / Playwright:

  • Color the text, not the text background. This improves readability
  • Change the reporter to line in CI and list locally. Before we used html in CI but we didn't do anything with the output

Example of new output: https://github.com/clerk/javascript/actions/runs/7058789001/job/19215097030?pr=2243

Before:

image

After:

image

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: b71d0cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@LekoArts LekoArts marked this pull request as ready for review December 1, 2023 10:30
@LekoArts LekoArts added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 0d52e23 Dec 1, 2023
7 checks passed
@LekoArts LekoArts deleted the fix-playwright-logging branch December 1, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants