Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js): Create UI Retheme Changes Reminder GitHub workflow #2225

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Nov 28, 2023

Description

Add a GitHub Action to comment on any PR that changes files under the clerk-js/ui directory.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: e0cee73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef anagstef force-pushed the test-retheme-commenter branch 2 times, most recently from abac8a2 to 3ee9e95 Compare November 28, 2023 22:01
@clerk clerk deleted a comment from github-actions bot Nov 28, 2023
@clerk clerk deleted a comment from github-actions bot Nov 28, 2023
@clerk clerk deleted a comment from github-actions bot Nov 28, 2023
@clerk clerk deleted a comment from github-actions bot Nov 28, 2023
Copy link
Contributor

github-actions bot commented Nov 28, 2023

⚠️ Changes detected under the ClerkJS ui directory!

Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**

Also, you may need to update the following files:

  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts

@anagstef anagstef requested a review from dimkl November 28, 2023 22:45
@anagstef anagstef changed the title [WIP] chore(clerk-js): Create UI Retheme Changes Reminder GitHub workflow chore(clerk-js): Create UI Retheme Changes Reminder GitHub workflow Nov 28, 2023
Copy link
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Can we use this only on branches with main base branch? In release/v4 there will never be a ui.retheme directory.

@anagstef anagstef added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 11a05e3 Nov 29, 2023
7 checks passed
@anagstef anagstef deleted the test-retheme-commenter branch November 29, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants