Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js): Retheme <UserButton /> #2212

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Nov 24, 2023

Description

This PR rethemes the UserButton component.

Newly introduced descriptors:

cl-userButtonPopoverActions__multiSession
cl-userButtonPopoverActions__singleSession
cl-userButtonPopoverActionButton__addAccount
cl-userButtonPopoverActionButtonIconBox__addAccount
cl-userButtonPopoverActionButtonIcon__addAccount
cl-userButtonPopoverActionButtonText__addAccount
cl-userButtonPopoverActionButton__signOutAll
cl-userButtonPopoverActionButtonIconBox__signOutAll
cl-userButtonPopoverActionButtonIcon__signOutAll
cl-userButtonPopoverActionButtonText__signOutAll
cl-userPreviewAvatarIcon

Screenshots

Screenshot 2023-11-24 at 22 07 27
Screenshot 2023-11-24 at 22 06 57

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Nov 24, 2023

🦋 Changeset detected

Latest commit: 5fba51f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef anagstef marked this pull request as draft November 24, 2023 20:24
@anagstef anagstef marked this pull request as ready for review November 28, 2023 14:00
@anagstef anagstef changed the title [WIP] feat(clerk-js): Retheme <UserButton /> feat(clerk-js): Retheme <UserButton /> Nov 28, 2023
@marcelscruz
Copy link
Contributor

Overall it lgtm. 🚀
I believe we could be as thorough as possible with the descriptors so as to give extensive flexibility to our users when it comes to targeting dom elements, but use your own judgment to know when it's necessary.

Copy link
Contributor

@marcelscruz marcelscruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anagstef anagstef force-pushed the stefanos/sdk-959-userbutton-retheme branch from 62d0729 to 801a826 Compare November 28, 2023 19:52
@desiprisg desiprisg force-pushed the stefanos/sdk-959-userbutton-retheme branch from bca94e3 to 83f0725 Compare November 29, 2023 09:52
@anagstef anagstef force-pushed the stefanos/sdk-959-userbutton-retheme branch from 83f0725 to 5fba51f Compare November 29, 2023 11:35
Copy link
Contributor

@desiprisg desiprisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@anagstef anagstef added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 13db4b4 Nov 29, 2023
7 checks passed
@anagstef anagstef deleted the stefanos/sdk-959-userbutton-retheme branch November 29, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants