Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Introduce OrganizationPermissionAPI #2178

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

panteliselef
Copy link
Member

Description

Add OrganizationPermissionAPI for CRUD operations regarding instance level organization permissions.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 677c99f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/clerk-sdk-node Patch
@clerk/backend Patch
@clerk/nextjs Patch
gatsby-plugin-clerk Patch
@clerk/fastify Patch
@clerk/remix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

export type PermissionType = 'system' | 'user';

/**
* @deprecated In the next major release this type will change to string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 If we have added the OrganizationMembershipRole in v4 (release/v4), we could add the deprecation in the v4 version and replace it with the new API in v5 version (main branch)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what i was thinking, I merge this and backport it and then create another PR to address this that will not be backported

@panteliselef panteliselef added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 0ce0edc Nov 22, 2023
7 checks passed
@panteliselef panteliselef deleted the elef/core-865-permissions-api branch November 22, 2023 12:53
panteliselef added a commit that referenced this pull request Dec 4, 2023
github-merge-queue bot pushed a commit that referenced this pull request Dec 4, 2023
…RoleAPI (#2252)

* Revert "feat(backend): Introduce OrganizationRoleAPI (#2177)"

This reverts commit b3a3dcd

* Revert "feat(backend): Introduce OrganizationPermissionAPI (#2178)"

This reverts commit 0ce0edc

* chore(backend): Add changeset

* chore(backend): Keep the previous changesets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants