feat(clerk-js): Retheme design and arrow on primary button #2121
Conversation
🦋 Changeset detectedLatest commit: 57bd419 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marcelscruz
changed the title
There was a problem hiding this comment.
@marcelscruz 🙃 Am I crazy or does the arrow look off-center (vertically) from the text?
@tmilewski It does indeed, but it's the same as the Figma file.
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
| borderRadius: 'inherit', | ||
| zIndex: -1, | ||
| inset: 0, | ||
| background: 'linear-gradient(180deg, rgba(255, 255, 255, 0.10) 0%, rgba(255, 255, 255, 0.00) 100%)', |
There was a problem hiding this comment.
Can we also move this literal value? And also use the color variables instead of hardcoded colors?
There was a problem hiding this comment.
We need to use colorPrimary somehow here, in order for this to be themable.
There was a problem hiding this comment.
Nevermind, didn't understand that correctly. This property actually creates the shadow effect on the button, so no need to change anything
desiprisg
force-pushed
the
retheme-primary-button
branch
from
7d64fbd
to
67d2a62
Compare
chore(clerk-js): Add changeset Remove content from changeset file chore(clerk-js): Move new arrow to separate file chore(clerk-js): Make button shadow a reusable util chore(clerk-js): Use theme values on arrow icon fix(clerk-js): Remove invalid color shades
desiprisg
force-pushed
the
retheme-primary-button
branch
from
67d2a62
to
57bd419
Compare
Description
This PR adds the new design and arrow on the primary button.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore