Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ESLint corrections #1982

Merged
merged 9 commits into from
Nov 15, 2023
Merged

refactor: ESLint corrections #1982

merged 9 commits into from
Nov 15, 2023

Conversation

tmilewski
Copy link
Member

Description

Corrections based on the parent PR's ESLint configuration. Package-specific changes are split out by commit.

These are "auto-fixes" with a bit of hand holding.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@tmilewski tmilewski self-assigned this Oct 31, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: d641733

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikosdouvlis
Copy link
Member

@tmilewski is this still valid?

@tmilewski tmilewski requested a review from a team as a code owner November 8, 2023 22:08
@tmilewski tmilewski force-pushed the tom/eslint-corrections branch 2 times, most recently from 7c0a7e7 to a962301 Compare November 8, 2023 22:28
@tmilewski
Copy link
Member Author

@tmilewski is this still valid?

@nikosdouvlis I rebased everything. Feel free to review. Each commit corresponds to updates within a particular package.

@tmilewski tmilewski added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 8e55d3a Nov 15, 2023
6 checks passed
@tmilewski tmilewski deleted the tom/eslint-corrections branch November 15, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants