Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): Use origin/main for changesets for main branch #1949

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Oct 26, 2023

Description

In main-v4 we are gonna use the origin/main-v4 as base branch but in main we need to produce a changelog from the origin/main. This difference between the 2 branches is intended to avoid duplicate entries or incorrect changelog entries.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

In `main-v4` we are gonna use the `origin/main-v4` as base branch but
in `main` we need to produce a changelog from the `origin/main`
@dimkl dimkl self-assigned this Oct 26, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

🦋 Changeset detected

Latest commit: 1863bb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nikosdouvlis nikosdouvlis merged commit fa901ab into main Oct 26, 2023
12 checks passed
@nikosdouvlis nikosdouvlis deleted the fix-v5-changeset-lane branch October 26, 2023 21:42
tmilewski pushed a commit that referenced this pull request Nov 17, 2023
* fix(repo): Use origin/main for changesets for main branch

In `main-v4` we are gonna use the `origin/main-v4` as base branch but
in `main` we need to produce a changelog from the `origin/main`

* Create spotty-roses-push.md
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants