Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please change the way "default" layers are shown on the map #84

Closed
4 tasks
DenoBeno opened this issue Feb 10, 2020 · 14 comments
Closed
4 tasks

Please change the way "default" layers are shown on the map #84

DenoBeno opened this issue Feb 10, 2020 · 14 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request on-hold Issue is on-hold and will be addressed later

Comments

@DenoBeno
Copy link

DenoBeno commented Feb 10, 2020

While testing for clarity-h2020/data-package#59, I realised that following things need to be changed for the "default" layers presentation:

  • Remove the "built up areas". This information is now spread over 3+2 "building" layers, the build up areas layer doesn't/will not exist anymore.
  • Add the "sport facilities" layer. It's missing from the map now. (ask @negroscuro for details)
  • Make it possible to choose zero to n "default" layers, like we do for the background layers now. These layers don't overlap, this makes them perfect for multi-layer screenshots.
  • Maybe also rename this layers group? (e.g. "CLARITY backgrounds"?)

Last point is mostly cosmetics, but there is a bit of overlap between "background" and "default" layers. Maybe we should merge the two groups and drop the overlapping layers?

Or call this "CLARITY background" as opposed to background layers from other sources? That would IMO be a good think, e.g. to be able to demonstrate the difference between the urban atlas "buildings" layers and ours.

@DenoBeno DenoBeno added enhancement New feature or request bug Something isn't working labels Feb 10, 2020
@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Feb 10, 2020

  • Remove the "built up areas". This information is now spread over 3+2 "building" layers, the build up areas layer doesn't/will not exist anymore.
  • Add the "sport facilities" layer. It's missing from the map now. (ask @negroscuro for details)

O.K. This is a modification of the respective resources the European Data Package. I can look into this.

Make it possible to choose zero to n "default" layers, like we do for the background layers now. These layers don't overlap, this makes them perfect for multi-layer screenshots.

Considering how resources and references are modelled in CSIS Drupal, this is currently not possible without changing the data model. We could add a boolean field 'selected' to the resource entity type, however, since a resource can contain multiple references (service paths) each of which is expanded into a separate layer, all layers of the resources would be selected. This is e.g. the case for the EEA Discovery Map Services Resource, which consists of 8 different references and layers respectively. Furthermore, since resources can be arbitrarily combined in data packages, it would be counter productive to define the default selection status at the level of the resource. It would have to be defined at the level of the data package making the data package data model and thus the data package from more complex (keeping information on the state of resources).

Maybe we should merge the two groups and drop the overlapping layers?

No those are conceptually different things. The name 'default' is just a fallback name if no hazard type is associated with the resource, e.g. for exposure resources.

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Feb 10, 2020

Make it possible to choose zero to n "default" layers, like we do for the background layers now. These layers don't overlap, this makes them perfect for multi-layer screenshots.

O.K. Now I understand what you mean by 'default' layers. You are talking about the Hazard LE Input Layers in the HC-LE step. The layer group name 'default' is misleading but as before, it is just a fallback name. What we can do without changing data models, etc. is use the name of the GL step as group title, in this case 'Hazard Characterization - Local Effects'.

ATM it's not easily possible to chose more than one because of this request.

@p-a-s-c-a-l p-a-s-c-a-l added the on-hold Issue is on-hold and will be addressed later label Feb 20, 2020
@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Feb 21, 2020

we could introduce a new 'category' tag at the level of the resource, so that layers are sorted into the respective category-folders of the Map Component's layer widget.

See clarity-h2020/data-package#21 (comment)

@claudiahahn
Copy link

ATM it's not easily possible to chose more than one because of this request.

Sorry for any confusion. My request was mainly to be able to unselect layers. I agree that it would be nice to be able to select more than 1 background layer for display. This might also become important for the basic screening method.

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Feb 27, 2020

select more than 1 background layer for display

This is currently possible. Background Layers have check boxes (0-n selectable) any another layers have de-selectable option boxes (0-1 selectable). The reason is simple: Most background layers are based on vector data and are partially transparent, so it makes sense to show several of them in one map (buildings + roads + vegetation, ...). Any other layers are in most cases gridded raster layers, so showing more than one at a time does not offer any benefit because they obscure each other.

Of course, we've got also some non-transparent background layers and a few transparent 'other' layers (the 'default' Urban-Atlas based HC-LE input layers for example). So the current solution is not optimal, but IMHO a compromise we can live with.

While we could implement an exception for the HC-LE input layers and allow multi-selection via checkboxes as suggested above, we have to be aware that HC-LE includes also non-transparent raster layers (TMRT, etc.) calculated by EMIKAT.

There was also an idea to allow user to overlay several layers and decide how to colour-code each, but this is technically difficult to implement on client side and the current situation does not allow us to invest effort on costly features.

@claudiahahn
Copy link

Thanks for clarifying!

I don't think it will be necessary to let the user decide how to color code layers. For a basic screening we could decide upfront which layers should have what color and we could write in plain text, which layers to select in order to display potentially critical areas.

Or call this "CLARITY background" as opposed to background layers from other sources? That would IMO be a good thing, e.g. to be able to demonstrate the difference between the urban atlas "buildings" layers and ours.

That sounds like a good idea to me. Also, adding original urban atlas layers (if they are available anyway) might be nice for the user to explore the area.

@DenoBeno
Copy link
Author

DenoBeno commented Feb 27, 2020 via email

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Feb 28, 2020

I've introduced a new tag clarity-background-layer, tagged the HC-LE input layers accordingly and removed the EU-GL local-effects tag from these layers (reason explained here). HC-LE output layers (UTCI, TMRT, ..) are not affected.

grafik

Map Component on csis.myclimateservice.eu (which is still on old DEV server) is updated.

@negroscuro Can you please create an new resource for the sports layer in the European Wide Data Package. Please tag it with clarity-background-layer, not with background-layer and local-effects. Thanks!

@negroscuro
Copy link

negroscuro commented Mar 3, 2020

I just updated CKAN with new sports data:
https://ckan.myclimateservice.eu/dataset/sports

Then I modified built_up obsolete entry in CSIS under 'European wide data package' (https://csis.myclimateservice.eu/node/682), to match new 'sports' layer which now is:
https://csis.myclimateservice.eu/node/3637

@ghilbrae
Copy link

ghilbrae commented Mar 4, 2020

@negroscuro can you please update the two resources in CKAN with proper URLs or files to the actual data? This way they lead to nowhere. Thanks!!

@p-a-s-c-a-l
Copy link
Member

done

@negroscuro
Copy link

negroscuro commented Mar 13, 2020

@ghilbrae sorry I missplaced URL,
The form resource name was containing the resource URL, so I put the name there and then I added the link field where I placed the URL and now seems to be working. I also updated Sports WMS link.

I also realized that most URL's of resources in CKAN defined by me are using URL's of request to Geoserver with specific bounding boxes and probably when contents get bigger that bbox should be updated in order to be able get/see the whole dataset.

@ghilbrae
Copy link

@negroscuro Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request on-hold Issue is on-hold and will be addressed later
Projects
None yet
Development

No branches or pull requests

6 participants