Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General UI Improvements #45

Closed
4 of 8 tasks
p-a-s-c-a-l opened this issue Dec 13, 2018 · 21 comments
Closed
4 of 8 tasks

General UI Improvements #45

p-a-s-c-a-l opened this issue Dec 13, 2018 · 21 comments
Assignees
Labels
BB: UI Integration Platform UI Integration Platform Building Block SHOWSTOPPER Feature or bug, that, if not addressed, renders the CSIS essentially useless STALLED important but currently not beeing worked on

Comments

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Dec 13, 2018

Here we collect some important improvements to the user interface that need to be addressed for CSIS v1.

  • Landing Page
  • Remove admin controls for non-admin users
  • better separation between study and GL-step tabs
  • Progress Indicator
  • better separation between prototype implementation and mock-ups
  • Update Taxonomies
  • Open Taxonomies' description in popups or inline (Study type, sector)
  • remove links on Taxonomies in study ( country)
@p-a-s-c-a-l p-a-s-c-a-l added the SHOWSTOPPER Feature or bug, that, if not addressed, renders the CSIS essentially useless label Dec 13, 2018
@p-a-s-c-a-l p-a-s-c-a-l added this to the D1.3 CLARITY CSIS v1 milestone Dec 13, 2018
@p-a-s-c-a-l
Copy link
Member Author

p-a-s-c-a-l commented Dec 13, 2018

Landing Page

If you visit https://csis.myclimateservice.eu/ as non-member, a landing page with explanations (what can expect from the csis, etc.) should be shown. Get in touch with the @clarity-h2020/dissemination-team and ask them to provide some editorially prepared statements. Information about the CSIS can be found in the mission statement of the CSS Architecture (D4.2 on OwnCloud) and WP5 Business Plan Canvas (ask Denis, Jorge or Andrea).

@p-a-s-c-a-l
Copy link
Member Author

p-a-s-c-a-l commented Dec 13, 2018

Remove admin controls for non-admin users

grafik

grafik

@p-a-s-c-a-l
Copy link
Member Author

better separation between study and GL-step tabs

GL-step tabs should be smaller, compare Mockup vs. Implementation

Mockup
grafik

Drupal
grafik

@p-a-s-c-a-l
Copy link
Member Author

Progress Indicator

Indicate to the user, that the the study follow a x-step progress. Current step should be highlighted.
All steps but the first step should be locked (tab visible but disabled), next step should be unlocked when the previous step has been completed (visited).

grafik

grafik

@p-a-s-c-a-l
Copy link
Member Author

p-a-s-c-a-l commented Dec 13, 2018

Better separation between prototype implementation and mock-ups

Remove prototype tab and move the content on top of mock-up tabs. Mock-Up tab remains closed. Ensure the content doesn't show any "under construction" placeholder but at least a (html) wireframe implementation of the mock-up.

grafik

Update therter/15.01.19: I have already done this for the tabs Table and Map, because the initialisation of the used components works different when the prototype tab is used.

@p-a-s-c-a-l
Copy link
Member Author

Update Taxonomies

This is a very important task. IMHO @DanielRodera could easily take care about this as it's a pure editorial task and does not involve structural changes or module development.

Please act proactively and add missing taxonomy terms and their descriptions.

  • for Sectors please select a standard for economic sectors e.g. from world bank, eu-gl, eurostat, etc.
  • for EU-GL Steps description consult D3.1 for EU-GL module description, for HC-LE description contact PLINIVUS. Ignore sub-taxonomy terms (Open Spaces/Surface Temperature) as I'm not sure if we gonna need them.
  • High Quality Descriptions + Images of Exposure (Elements at Risk) and Hazard Types are extremely important for the visualisation of Data Packages! Get in touch with PLINIVS and the WP3 for a list of supported Hazards and Exposure and ask the @clarity-h2020/dissemination-team to polish the descriptions and provide pictures.**

Example: Flood Hazard
grafik

Example: Buildings Exposure
grafik

@patrickkaleta
Copy link
Contributor

Regarding the Landingpage:

Drupal offers the possibility to set one front page (/admin/config/system/site-information). We could create a content entity of type Basic page and fill it with general information that would be displayed to everyone (logged in and anonymous users).

We could then place a block at the top of this content, which would display more basic information just for anonymous (=not logged in) users when they visit https://csis.myclimateservice.eu/.
For logged in users we could use a different block, which could display a list with e.g. the latest studies?

@p-a-s-c-a-l
Would that work for you? If we really want two completely seperate landingpages for logged in and not logged in users, we would need the Rules Module, which is for Drupal 8 currently only in alpha version. Maybe @fgeyer16 also has another idea how we could deal with the frontpage/landingpage?

Also Pascal, could you send me the e-mail adress of @DeliaModest so that I can contact her? Couldn't find her mail address on the CLARITY contact list and on GitHub it's not visible to me.

@p-a-s-c-a-l
Copy link
Member Author

p-a-s-c-a-l commented Dec 14, 2018

Drupal offers the possibility to set one front page (/admin/config/system/site-information).

Yes, that's a good solution. We don't need two different landing pages for members and non-members. And since the main entry page is myclimateservice.eu, for the "About CSIS Block" we could simply reuse or summarise the editorial content about the CSIS that (has / will be ?) produced for myclimateservice.eu.

@fgeyer16
Copy link

fgeyer16 commented Dec 19, 2018

Regarding the progress Indicator:

All steps but the first step should be locked (tab visible but disabled), next step should be unlocked when the previous step has been completed (visited).

How do we determine that the step has been visited? I propose an additional field which gets a certain value on the first visit. In this case we can easily extend the functionality to a certain field is filled in the step later. We can query this field in the navigation creation view and inactivate the following steps.
better separation between study and GL-step tabs

regarding the better separation between study and GL-step tabs:

This should be done in css only and is so becomming a task of this issue on clarity-theme

@p-a-s-c-a-l
Copy link
Member Author

I propose an additional field which gets a certain value on the first visit.

Sounds reasonable.

@therter
Copy link
Contributor

therter commented Jan 15, 2019

Regarding "Better separation between prototype implementation and mock-ups"

I have already done this for the tabs Table and Map, because the initialisation of the used components works different when the prototype tab is used.

@p-a-s-c-a-l p-a-s-c-a-l added the BB: UI Integration Platform UI Integration Platform Building Block label Jan 15, 2019
@p-a-s-c-a-l p-a-s-c-a-l changed the title General UI Improvments General UI Improvements Jan 15, 2019
@fgeyer16
Copy link

fgeyer16 commented Jan 22, 2019

Demo user only should see the DC1 Study and has no rights to change anything.
The admin toolbar has to be not available for the Demo user (in the moment there is an issue concerning the navigation, which is dissapearing on deactivation of the toolbar)

add contact link on Study team overview. Full name and not username should be shown on the team overview

@patrickkaleta
Copy link
Contributor

Regarding the landing page:

Landing page has been implemented. I installed a new module to create a slideshow. Additionally, I added a new boolean field to the content type "Basic page" to determine whether a basic page shall be displayed in the slideshow or not.

Currently this slideshow is displayed to everyone (logged-in users and anonymous users), but this can easily be changed once we have more content.

@patrickkaleta
Copy link
Contributor

Regarding "Remove admin controls for non-admin users"

I deactivated the toolbar and the control & edit buttons for non-admin users.

As mentioned above there was this problem with the navigation disappearing, when the toolbar was deactivated. This seems to be fixed now as well. I wasn't able to find the exact reason but I believe it was some caching issue together with the display mode of the individual tabs.

@patrickkaleta
Copy link
Contributor

Regarding the progress indicator

This has been implemented by adding a new field "Progress indicator" in the Group-type "Study". When a new study is created, this field is initialized with the value 1 and only the first step can be accessed in the navigation.

At the moment, when the user visits any of the tabs in the current step, the value is incremented and the next step gets activated in the navigation. This behaviour can later be adapted, once it is clear at which point each step can be considered "completed".

@patrickkaleta
Copy link
Contributor

Update regarding Landing page

I added a block to the landing page displaying all available studies. For that i updated the "Study" Group, so that now it can be set whether a Study should be made public (=visible on the CSIS for others) or not. This functionality was added accordingly to what Denis proposed during our last developer meeting. For now I only set Study 1 to be public.

I added another overview displaying all studies, which the user is a member of. This table can be found on the user profile under the tab "My studies" (URL: /user/[USERID]/studies)

@p-a-s-c-a-l
Copy link
Member Author

Regarding "Better separation between prototype implementation and mock-ups"

I have already done this for the tabs Table and Map, because the initialisation of the used components works different when the prototype tab is used.

@therter so maybe you could take care of the other Tabs/Steps as well?

@p-a-s-c-a-l
Copy link
Member Author

I've resolved 'better separation between prototype implementation and mock-ups'

@p-a-s-c-a-l
Copy link
Member Author

'better separation between study and GL-step tabs' is probably just a small CSS modification. This could be done Alejandro? I've invited him to join UI Team.

@p-a-s-c-a-l
Copy link
Member Author

Open Taxonomies' description in popups or inline (Study type, sector)

When you click on 'energy' (should be renamed to Energy, btw), a popup should be opened

grafik

I modified the view to show the taxonomy terms inline but but this looks bad:

grafik

@DanielRodera maybe you can have a look and ask Alejandro to take care about 'better separation between study and GL-step tabs'?

@p-a-s-c-a-l p-a-s-c-a-l added the STALLED important but currently not beeing worked on label Jul 1, 2019
@p-a-s-c-a-l
Copy link
Member Author

I expect that pending issues have been fixed in the new CLARITY Theme which just has to be activated and tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB: UI Integration Platform UI Integration Platform Building Block SHOWSTOPPER Feature or bug, that, if not addressed, renders the CSIS essentially useless STALLED important but currently not beeing worked on
Projects
None yet
Development

No branches or pull requests

5 participants