Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata-extended not added correctly in cjio upgrade #125

Open
ozgetufan opened this issue Dec 8, 2021 · 1 comment
Open

metadata-extended not added correctly in cjio upgrade #125

ozgetufan opened this issue Dec 8, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ozgetufan
Copy link

ozgetufan commented Dec 8, 2021

I used cjio to first upgrade a CityJSON file from v1.0 to v1.1, then to filter only lod 2, which converted many metadata information using the MetadataExtended extension. However, the "spatialRepresentationType" property is not converted correctly. According to the schema of MetadataExtended, type of this property needs to be an array of strings, but it was converted as string.

image

image

When I change the value to ["vector"], my file becomes valid so I guess there is a problem in cjio upgrade about this.

@ozgetufan
Copy link
Author

I just realized that all information in "+metadata-extended" object is only included once I filter LoD. Before this, there is only "presentLoDs" in "+metadata-extended", but once I use cjio to filter LoD2, many other properties are added (image below) that are not present in the original file.

image

While this does not create a problem, there is one error I've gotten related to this: In "cityfeatureMetadata", a property called "BuildingParts" is included which is not specified in the schema of MetadataExtended extension. Additional properties are not allowed in the schema so this gives an error.

I include the files in the zip below, both before LoD filter (multipart_v11.json) and after (multipart_v11_lod2.json)

cityjson_files.zip

@hugoledoux hugoledoux self-assigned this Dec 9, 2021
@hugoledoux hugoledoux added the bug Something isn't working label Dec 9, 2021
@balazsdukai balazsdukai added this to the v0.8.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants