Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update citus.spec template file to be able to put NOTICE file into packages #209

Open
gurkanindibay opened this issue Nov 29, 2021 · 1 comment

Comments

@gurkanindibay
Copy link
Contributor

Recently we added NOTICE files into rpm and deb packages. RPM spec file has changed. In each version spec file is being created using the template files so that changes overwritten. templates for citus should be changed to fix this erronous overwrite operation

@hanefi
Copy link
Member

hanefi commented Mar 31, 2022

We added the NOTICE file on Citus v10.0.0. When we want to release a package for a version that is earlier than that, we should remove the NOTICE file definitions manually now.

Another option is to check the current version in the rpm spec and include the NOTICE file for versions >= 10.0.0. I do not think that it is worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants