Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hll's upgrade sql files are copied/installed with wrong names causing extension test failures. #265

Open
emelsimsek opened this issue Jan 24, 2023 · 0 comments
Labels

Comments

@emelsimsek
Copy link

When testing hll extension, setup.sql test for the extension fails. But this is a test setup issue. The sql files for the upgrade is not named appropriately in the test environment. See below file names.

diff -U3 /home/pguser/code/postgresql-hll/expected/setup.out /home/pguser/code/postgresql-hll/results/setup.out
--- /home/pguser/code/postgresql-hll/expected/setup.out 2023-01-24 10:02:49.591282689 +0000
+++ /home/pguser/code/postgresql-hll/results/setup.out 2023-01-24 10:02:53.639283737 +0000
@@ -1,7 +1,13 @@
CREATE EXTENSION hll VERSION '2.10';
ALTER EXTENSION hll UPDATE TO '2.11';
+ERROR: extension "hll" has no update path from version "2.10" to version "2.11"
ALTER EXTENSION hll UPDATE TO '2.12';
+ERROR: extension "hll" has no update path from version "2.10" to version "2.12"
ALTER EXTENSION hll UPDATE TO '2.13';
+ERROR: extension "hll" has no update path from version "2.10" to version "2.13"
ALTER EXTENSION hll UPDATE TO '2.14';
+ERROR: extension "hll" has no update path from version "2.10" to version "2.14"
ALTER EXTENSION hll UPDATE TO '2.15';
+ERROR: extension "hll" has no update path from version "2.10" to version "2.15"
ALTER EXTENSION hll UPDATE TO '2.16';
+ERROR: extension "hll" has no update path from version "2.10" to version "2.16"

[pguser@citustestclustervm0 ~]$ ls -al postgres-installation/share/postgresql/extension/hll*
-rw-r--r--. 1 pguser pguser 12895 Jan 24 10:09 postgres-installation/share/postgresql/extension/hll--2.10.sql
-rw-r--r--. 1 pguser pguser 14061 Jan 24 10:09 postgres-installation/share/postgresql/extension/hll--2.11.sql
-rw-r--r--. 1 pguser pguser 14122 Jan 24 10:09 postgres-installation/share/postgresql/extension/hll--2.12.sql
-rw-r--r--. 1 pguser pguser 14183 Jan 24 10:09 postgres-installation/share/postgresql/extension/hll--2.13.sql
-rw-r--r--. 1 pguser pguser 14244 Jan 24 10:09 postgres-installation/share/postgresql/extension/hll--2.14.sql
-rw-r--r--. 1 pguser pguser 19124 Jan 24 10:09 postgres-installation/share/postgresql/extension/hll--2.15.sql
-rw-r--r--. 1 pguser pguser 19185 Jan 24 10:09 postgres-installation/share/postgresql/extension/hll--2.16.sql

-rw-r--r--. 1 pguser pguser 709 Jan 24 10:09 postgres-installation/share/postgresql/extension/hll.control

[pguser@citustestclustervm0 ~]$ ls -al /home/pguser/code/postgresql-hll/
total 336
drwxrwxr-x. 9 pguser pguser 4096 Jan 24 12:32 .
drwxrwxr-x. 6 pguser pguser 4096 Jan 24 10:10 ..
-rw-r--r--. 1 pguser pguser 46 Jan 24 10:09 binary.dat
-rw-rw-r--. 1 pguser pguser 1592 Jan 24 10:09 CHANGELOG.md
-rw-rw-r--. 1 pguser pguser 464 Jan 24 10:09 DEVELOPER.md
drwxrwxr-x. 2 pguser pguser 4096 Jan 24 10:09 expected
drwxrwxr-x. 8 pguser pguser 4096 Jan 24 10:09 .git
-rw-rw-r--. 1 pguser pguser 107 Jan 24 10:09 .gitignore
-rw-rw-r--. 1 pguser pguser 1166 Jan 24 10:09 hll--2.10--2.11.sql
-rw-rw-r--. 1 pguser pguser 12895 Jan 24 10:09 hll--2.10.sql
-rw-rw-r--. 1 pguser pguser 61 Jan 24 10:09 hll--2.11--2.12.sql
-rw-rw-r--. 1 pguser pguser 14061 Jan 24 10:09 hll--2.11.sql
-rw-rw-r--. 1 pguser pguser 61 Jan 24 10:09 hll--2.12--2.13.sql
-rw-rw-r--. 1 pguser pguser 14122 Jan 24 10:09 hll--2.12.sql
-rw-rw-r--. 1 pguser pguser 61 Jan 24 10:09 hll--2.13--2.14.sql
-rw-rw-r--. 1 pguser pguser 14183 Jan 24 10:09 hll--2.13.sql
-rw-rw-r--. 1 pguser pguser 4880 Jan 24 10:09 hll--2.14--2.15.sql
-rw-rw-r--. 1 pguser pguser 14244 Jan 24 10:09 hll--2.14.sql
-rw-rw-r--. 1 pguser pguser 61 Jan 24 10:09 hll--2.15--2.16.sql
-rw-rw-r--. 1 pguser pguser 19124 Jan 24 10:09 hll--2.15.sql
-rw-rw-r--. 1 pguser pguser 19185 Jan 24 10:09 hll--2.16.sql

-rw-rw-r--. 1 pguser pguser 709 Jan 24 10:09 hll.control

@emelsimsek emelsimsek added the bug label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant