Something missing in comment menu

[loorm]

What is the problem?
There's something missing, see screenshot.

Why is this a problem?
If you don't notice the rectangle, it is difficult to find edit and delete comment options.

Possible solution.
Replace the rectangle with whatever was supposed to be there.

[loorm]

Triage 20 - change this from FontAwesome to custom graphics. Do the same for inline comments and inline votes plugins. Est dev time 4 hrs.

[tiblu]

Done!

[oksks]

@tiblu, 2 questions:

1. Why do we allow editing someone else's reply btw - is that by design?
2. Why is the edit button hidden behind the 3 dots, instead of just displaying the edit button? Why is the extra click needed.. I understand if there were several options to choose from, but there's just one.

[tiblu]

@oksks Appreciate the attention to detail!

I restored the state of the UI to reflect the design as I think it was before the icon got lost.
And I cannot comment on the other issues. Maybe @ilmartyrk can shed some light.

My thoughts tho:

Why do we allow editing someone else's reply btw - is that by design?

Yeah, that is weird. Should not be allowed. Maybe thats how original EP comments was implemented by Etherpad? @ilmartyrk

Why is the edit button hidden behind the 3 dots, instead of just displaying the edit button? Why is the extra click needed.. I understand if there were several options to choose from, but there's just one.

Yeah, not consistent with the rest of the UX. I tried to find designs for the feature in Invision, but I did not find any. Maybe @ilmartyrk can comment how we came to this design.

[loorm]

@kevincrepin UX discussion here. Please have a look.

[kevincrepin]

Initially it was an arrow to indicate a dropdown menu. Not sure when it was turned into the kebab icon, maybe because of Etherpad :)

In any case, in our arguments section we have done some minor updates as to how we show all of this data, so I now also put these in the same line. There's an action menu that (can) open up edit, delete, report, probably not share?

https://projects.invisionapp.com/d/main#/console/9829159/301183006/preview
Let's keep this uniform and even when there is only one action available to the user because of their role, let's still keep it under the actions menu. Then the user learns about the consistent presence of actions.

[loorm]

@tiblu Kevin specified the design. Re-opening the issue.

[KatiVellak]

Editing someone else's reply should not be allowed. Has this been fixed?

[loorm]

Triage 22. Est dev time 4 hours. Prioritizing.

[tiblu]

TODO:

• Drop down menu
  
• Disable editing someone elses reply IF it is possible

[tiblu]

Depends on citizenos/citizenos-fe#466

After looking into it this there is no point of doing it before #466 is done.

THEN we either:

1. Try to sync our fork with latest https://github.com/ether/ep_comments and apply new menu visuals.
2. Make a clean fork of https://github.com/ether/ep_comments and re-do the whole visual design on top.

Either way, I feel like if I implement anything right now, it would be a waste of time.

[tiblu]

Created an issue to upstream on the comment/reply authorization issue - ether/ep_comments_page#125

[tiblu]

Editing someone else's reply should not be allowed. Has this been fixed?

@loorm @KatiVellak Unfortunately this is "by design", that is, this has never been a concern to other users - ether/ep_comments_page#125 (comment)

Which means, if we want this, we probably have to implement this. NO ETA, have to dig in deep.

[loorm]

I can't see a way around this. Editing someone else's comments simply is not cool. We have to work on this.

[ilmartyrk]

Closing it as the style has changed too much with EP 1.8.4 and editing other users comments is fixed