Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the llnl-scraper package from PyPI #148

Open
1 task
mcdonnnj opened this issue Aug 29, 2024 · 0 comments
Open
1 task

Install the llnl-scraper package from PyPI #148

mcdonnnj opened this issue Aug 29, 2024 · 0 comments

Comments

@mcdonnnj
Copy link
Member

💡 Summary

We should update the pipenv configuration in this project to install the llnl-scraper package from PyPI instead of LLNL/scraper.

Motivation and context

With #147 we (will) switch to installing the llnl-scraper package from the LLNL/scraper repository to get necessary changes. However, it would be preferable to install a minimum version from PyPI instead. Once a new version is released on PyPI with the necessary changes we should switch the dependency to that version as a minimum bound and install from PyPI as normal.

Implementation notes

Once the Pipfile is updated we need to update the Pipfile.lock lock file.

Acceptance criteria

How do we know when this work is done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant