Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsItCicada fails to verify compressed --sign messages #8

Open
crashdemons opened this issue Mar 26, 2022 · 1 comment
Open

IsItCicada fails to verify compressed --sign messages #8

crashdemons opened this issue Mar 26, 2022 · 1 comment
Assignees
@crashdemons
Labels
bug Something isn't working

Comments

@crashdemons
Copy link
Contributor

while isistcicada verifies --clearsign messages, it doesn't verify --sign messages yet.

While OpenPGP.JS supports this, the pre-validation steps IsItCicada does (as an attempt to add more warnings than OpenPGP and GPG do) overzealously excludes this message format.
@crashdemons crashdemons added the bug Something isn't working label Mar 26, 2022
@crashdemons crashdemons self-assigned this Mar 26, 2022
@crashdemons
Copy link
Contributor Author

This failure case is now represented in Test-Case 24 (when loading run_tests.html) with commit 24dc2b3

@crashdemons crashdemons mentioned this issue Mar 26, 2022
Merged
crashdemons added a commit that referenced this issue Mar 28, 2022
@crashdemons
Merge pull request #10 from cicada-solvers/fix-issue-8
e1bc913 
Fix issue #8 by detecting message type and calling proper methods + split header validation parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crashdemons crashdemons

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crashdemons