From 709711b491cc157132f1c0bdc9909184790dd3eb Mon Sep 17 00:00:00 2001
From: Christopher Timm <timm@effective-webwork.de>
Date: Tue, 18 Jun 2024 10:24:40 +0200
Subject: [PATCH] Codacy fix

---
 Classes/Common/MetsDocument.php                          | 7 ++-----
 Classes/Controller/MetadataController.php                | 4 ++--
 Classes/Domain/Repository/MetadataSubentryRepository.php | 2 +-
 Classes/ViewHelpers/IsArrayViewHelper.php                | 6 ++++--
 4 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/Classes/Common/MetsDocument.php b/Classes/Common/MetsDocument.php
index 95ea45676..d0b0d0ff9 100644
--- a/Classes/Common/MetsDocument.php
+++ b/Classes/Common/MetsDocument.php
@@ -932,13 +932,10 @@ private function getAdditionalMetadataFromDatabase(int $cPid, string $dmdId)
                 )
             )
             ->where(
-                $queryBuilder->expr()->eq('tx_dlf_metadata.pid', intval($cPid)),
-                // $queryBuilder->expr()->eq('tx_dlf_metadata.l18n_parent', 0),
-                // $queryBuilder->expr()->eq('tx_dlf_metadataformat_joins.pid', intval($cPid)),
+                $queryBuilder->expr()->eq('tx_dlf_metadata.pid', (int) $cPid),
                 $queryBuilder->expr()->gt('tx_dlf_metadataformat_joins.subentries', 0),
                 $queryBuilder->expr()->eq('tx_dlf_subentries_joins.l18n_parent', 0),
-                $queryBuilder->expr()->eq('tx_dlf_subentries_joins.pid', intval($cPid))
-            // $queryBuilder->expr()->eq('tx_dlf_formats_joins.type', $queryBuilder->createNamedParameter($this->dmdSec[$dmdId]['type']))
+                $queryBuilder->expr()->eq('tx_dlf_subentries_joins.pid', (int) $cPid)
             )
             ->orderBy('tx_dlf_subentries_joins.sorting')
             ->execute();
diff --git a/Classes/Controller/MetadataController.php b/Classes/Controller/MetadataController.php
index f8016e040..d188acb22 100644
--- a/Classes/Controller/MetadataController.php
+++ b/Classes/Controller/MetadataController.php
@@ -174,7 +174,7 @@ protected function printMetadata(array $metadata): void
                     $metadata[$i][$name] = is_array($value)
                         ? implode($this->settings['separator'], $value)
                         : $value;
-                    
+
                     if ($metadata[$i][$name] === 'Array') {
                         $metadata[$i][$name] = [];
                         foreach ($value as $subKey => $subValue) {
@@ -384,7 +384,7 @@ private function parseMetadata(int $i, string $name, $value, array &$metadata) :
                 $langValue = Helper::getLanguageName($langValue);
             }
         } elseif (!empty($value)) {
-          $metadata[$i][$name][0] = $metadata[$i][$name][0];
+            $metadata[$i][$name][0] = $metadata[$i][$name][0];
         }
     }
 
diff --git a/Classes/Domain/Repository/MetadataSubentryRepository.php b/Classes/Domain/Repository/MetadataSubentryRepository.php
index 8904b58c6..e5c3d94e1 100644
--- a/Classes/Domain/Repository/MetadataSubentryRepository.php
+++ b/Classes/Domain/Repository/MetadataSubentryRepository.php
@@ -15,4 +15,4 @@
 class MetadataSubentryRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
 {
 
-}
\ No newline at end of file
+}
diff --git a/Classes/ViewHelpers/IsArrayViewHelper.php b/Classes/ViewHelpers/IsArrayViewHelper.php
index 9e4a0dce1..19e72b1dc 100644
--- a/Classes/ViewHelpers/IsArrayViewHelper.php
+++ b/Classes/ViewHelpers/IsArrayViewHelper.php
@@ -11,6 +11,7 @@
  */
 
 namespace Kitodo\Dlf\ViewHelpers;
+
 use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
 
@@ -32,9 +33,10 @@ public static function renderStatic(
         array $arguments,
         \Closure $renderChildrenClosure,
         RenderingContextInterface $renderingContext
-    ) {
+    )
+    {
         $subject = $arguments['subject'];
-        if (null === $subject) {
+        if ($subject === null) {
             $subject = $renderChildrenClosure();
         }