Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build problems #12

Open
nathaniel-holder opened this issue Apr 6, 2018 · 7 comments
Open

Build problems #12

nathaniel-holder opened this issue Apr 6, 2018 · 7 comments

Comments

@nathaniel-holder
Copy link

I'm having trouble building this project, specifically with the RestSharp assembly. Is this a known issue? What .Net Framework is supported, and what version of Visual Studio? Sorry for newbie questions.

@christianrondeau
Copy link
Owner

No problem :) The solution should open with Visual Studio 2015 (though I've been running with 2017 for a while), and it's using .NET Framework 4.5.2.

What problem(s) do you have?

@nathaniel-holder
Copy link
Author

Ahh, I figured it out: the project TechTalk.JiraRestClient.csproj had an incorrect <HintPath>. Here's the diff:

diff --git a/TechTalk.JiraRestClient/TechTalk.JiraRestClient.csproj b/TechTalk.JiraRestClient/TechTalk.JiraRestClient.csproj
index e2b9e41..d289426 100644
--- a/TechTalk.JiraRestClient/TechTalk.JiraRestClient.csproj
+++ b/TechTalk.JiraRestClient/TechTalk.JiraRestClient.csproj
@@ -31,7 +31,7 @@
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="RestSharp">
-      <HintPath>..\packages\RestSharp.104.1\lib\net4-client\RestSharp.dll</HintPath>
+      <HintPath>..\..\..\packages\RestSharp.104.1\lib\net4-client\RestSharp.dll</HintPath>
     </Reference>
     <Reference Include="System" />
     <Reference Include="System.Core" />

@nathaniel-holder
Copy link
Author

I'm getting Jira authorization denied. Does this work with a cloud-based Jira account (eg with URL of https://<myproject>.atlassian.net)? If so, does it work with two-step authentication? Thanks so much!

@nathaniel-holder
Copy link
Author

Ahh, figured it out again: I needed to use an API token instead of password when Two-step authentication is enabled.

@christianrondeau
Copy link
Owner

Weird that you had to change the HintPath. Is RestSharp in \Modules\JiraRestClient\packages\RestSharp.104.1? How did you do the NuGet package restore?

@vipetrul
Copy link
Contributor

vipetrul commented Apr 7, 2018

The problem is how two subrepositories (JiraRestClient and C--Toggl-Api-Client) reference NuGet packages. They both are using relative path, which is a problem for this project, because location is NuGet packages is different.

I usually manually fix references before I build the project. Example of the change:
change this:
<HintPath>..\packages\RestSharp.104.1\lib\net4-client\RestSharp.dll</HintPath>
to this:
<HintPath>$(SolutionDir)\packages\RestSharp.104.1\lib\net4-client\RestSharp.dll</HintPath>

It would be ideal if those subrepo dependencies would use $(SolutionDir) to begin with.

@christianrondeau
Copy link
Owner

Agreed @vipetrul. It would probably be simpler to just get rid of these submodules and simply call the json APIs directly.. But that's a pretty minor inconvenience. A note in the readme may be warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants