You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For some reason the download from figshare test will randomly fail (I getting some of the metadata from figshare). It might just be an issue of making the timeout longer. However, I think it would be useful to basically just remove this function and revise how the downloads are performed. At this point, it is only used by some of the curation scripts; this, along with download from zenodo, can just be replaced with the more generic download_from_url function I added (which now also includes all the checksum validation as well). The figshare downloader would fetch the checksum from the record, along with file size; We can just set these as parameters (as this is how it is now done in the dataset loaders).
this is low priority, but is an easy bit of refactoring when doing some modifications to the phalkethoh curation as noted in issue #216 .
The text was updated successfully, but these errors were encountered:
For some reason the download from figshare test will randomly fail (I getting some of the metadata from figshare). It might just be an issue of making the timeout longer. However, I think it would be useful to basically just remove this function and revise how the downloads are performed. At this point, it is only used by some of the curation scripts; this, along with download from zenodo, can just be replaced with the more generic download_from_url function I added (which now also includes all the checksum validation as well). The figshare downloader would fetch the checksum from the record, along with file size; We can just set these as parameters (as this is how it is now done in the dataset loaders).
this is low priority, but is an easy bit of refactoring when doing some modifications to the phalkethoh curation as noted in issue #216 .
The text was updated successfully, but these errors were encountered: