Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test download from figshare test randomly fails in CI #224

Closed
chrisiacovella opened this issue Aug 9, 2024 · 1 comment
Closed

test download from figshare test randomly fails in CI #224

chrisiacovella opened this issue Aug 9, 2024 · 1 comment
Assignees

Comments

@chrisiacovella
Copy link
Member

For some reason the download from figshare test will randomly fail (I getting some of the metadata from figshare). It might just be an issue of making the timeout longer. However, I think it would be useful to basically just remove this function and revise how the downloads are performed. At this point, it is only used by some of the curation scripts; this, along with download from zenodo, can just be replaced with the more generic download_from_url function I added (which now also includes all the checksum validation as well). The figshare downloader would fetch the checksum from the record, along with file size; We can just set these as parameters (as this is how it is now done in the dataset loaders).

this is low priority, but is an easy bit of refactoring when doing some modifications to the phalkethoh curation as noted in issue #216 .

@chrisiacovella chrisiacovella self-assigned this Aug 9, 2024
@chrisiacovella
Copy link
Member Author

I resolved in this in PR #230 which is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant