(datagrip) When installing a new Datagrip minor version (e.g. 2023.2.0), an empty directory under Program Files (x86)\JetBrains\DataGrip 2023.2.0 is created
#2257
Comments
The workaround, and folder having to be created before the installer is run, can be removed as the issue has been fixed.
|
I've raised #2258 to fix this. |
9numbernine9
changed the title
Program Files (x86)\JetBrains\DataGrip 2023.2.0 is crreatedProgram Files (x86)\JetBrains\DataGrip 2023.2.0 is created
|
@pauby Is it too late to expand the scope of this issue? I just noticed that the exact same thing is happening with the WebStorm |
|
@9numbernine9 We prefer one PR per package but I think in this case it would make sense to have the same change, for multiple packages, in one PR. If you want to amend the title, and the original comment on this issue, and add checkboxes for the problematic packages, I can look at amending the PR. In the meantime I'll put #2258 in draft. |
|
@pauby I've looked through all of the Jetbrains packages (I think?) in the Chocolatey community repository and the only two that I think actually have this issue are |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
|
Still relevant. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Please do not add a comment to circumvent automatic closure unless you plan to help move it forward. |
When determining the installation directory for Datagrip, remove any `.0` suffix that might be present in the version number. Jetbrains doesn't use this part of the release version number when installing, so this causes Chocolatey to create an empty directory that never gets used or cleaned up. Fixes issue chocolatey-community#2257 .
|
Dear contributor, As this issue seems to have been inactive for quite some time now, I've automatically closed it. |
|
Still relevant - PR was raised so I'm not sure why this issue was closed. |
Chocolatey Version
2.1.0
Chocolatey License
None
Package Version
2023.2.0
Current Behaviour
Hello! 👋
When installing the latest version of DataGrip (
2023.2.0), line 9 sets the$installDirvariable to$programFiles\JetBrains\DataGrip $env:ChocolateyPackageVersion. Unfortunately, this value is not quite correct for new DataGrip minor versions: when a DataGrip version number ends in.0, the directory that the DataGrip installer will install itself into will omit the.0patch version.The end result of this is that we end up with two directories under
Program Files (x86):Program Files (x86)\JetBrains\DataGrip 2023.2, where the installer installed itself and placed all the code.Program Files (x86)\JetBrains\DataGrip 2023.2.0, an empty directory created by theChocolateyInstall.ps1script.Although this doesn't cause any errors, it is slightly confusing.
Expected Behaviour
Only one directory for a DataGrip install should be created, not two.
Steps To Reproduce
2023.2.0via Chocolatey.C:\Program Files (x86)\JetBrainsDataGrip 2023.2✅ andDataGrip 2023.2.0❌Environment
Chocolatey Log
Anything else?
No response
The text was updated successfully, but these errors were encountered: