(chocolatey-core.extension) Unescape app name pattern when calling 'Get-UninstallRegistryKey' #1210
Conversation
This is a compatibility fix to make the function compatible with Powershell V2. Without this fix the 'UninstallString'/'InstallLocation' value will always be null.
…et-UninstallRegistryKey' This is needed in some rare cases when there is an actual need to use a regex pattern when calling 'Get-AppInstallLocation'. fixes #784
|
✅ Package verification completed without issues. PR is now pending human review |
|
I am not sure anymore that is the right path to take here. Its also not certain that current packages work with this change, or I would add this one line change back when it was reported. Maybe better idea is to execute registry call 2 times, one with re and then with glob if re finds nothing. In this way there is lower probability that existing packages would bug up I think. Or try this after all checks failed which will definitely work with all existing packages. |
|
@majkinetor I did actually test a few packages after applying this change, which all seemed to work as expected. Having a call to execute the registry several times doesn't really seem right either. Pretty much the only thing that But I can do some more testing to make sure. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
|
Dear contributor, |
This is needed in some rare cases when there is an actual
need to use a regex pattern when calling 'Get-AppInstallLocation'.
fixes chocolatey-community/chocolatey-extensions#11
This PR is dependent on the previous PR I opened: #1209
Below is a list of which packages have been tested, both before the change (1.3.3) and after the change (1.3.4). Every package have been tested by installing to a custom directory (when possible), and directory not named the same as what checked for when calling
Get-AppInstallLocationMore to come