Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a small meta file with information about information regarding binary files #30

Open
AdmiringWorm opened this issue Sep 6, 2020 · 2 comments · May be fixed by #35
Open

Create a small meta file with information about information regarding binary files #30

AdmiringWorm opened this issue Sep 6, 2020 · 2 comments · May be fixed by #35
Labels
enhancement New feature or request
Milestone
0.2.0

Comments

@AdmiringWorm
Copy link
Member

Expected Behavior

Since binary files can't be compared directly, I expect there to be a small text file (meta file) available with the different information about each binary file located in the folders that can be used to compare wether or not the binaries have changed (and if they match the any specified checksum in the VERIFICATION.txt)

Current Behavior

All binaries are completely ignored.

Possible Solution

Write a small text file with all the found binaries, that would include name of binary, checksum and possibly version (if one can be found).
This may perhaps be done before comparing files, as then it would be part of comparing directories (#24) as well.

Context

Easier to compare

Your Environment

  • Script version used: latest master
  • Powershell Version used: PS 7.0.3
  • Operating System: Arch Linux
@mkevenaar
Copy link
Member

Acceptance criteria

That temporary metadata file should be deleted once the script is finished.

@mkevenaar mkevenaar added the enhancement New feature or request label Sep 6, 2020
@mkevenaar mkevenaar added this to the 0.2.0 milestone Sep 6, 2020
@AdmiringWorm
Copy link
Member Author

That temporary metadata file should be deleted once the script is finished.

Shouldn't be needed IMO, as it should be located inside the directories so it would be deleted unless the user uses the keepFiles argument.

AdmiringWorm added a commit to AdmiringWorm/chocolatey-diff that referenced this issue Oct 5, 2020
@AdmiringWorm
(chocolatey-communityGH-30) Add ability to compare meta information o…
89b6799 
…f found binaries
@AdmiringWorm AdmiringWorm linked a pull request Oct 5, 2020 that will close this issue
Draft
9 tasks
AdmiringWorm added a commit to AdmiringWorm/chocolatey-diff that referenced this issue Oct 13, 2020
@AdmiringWorm
(chocolatey-communityGH-30) Add ability to compare meta information o…
0655430 
…f found binaries
AdmiringWorm added a commit to AdmiringWorm/chocolatey-diff that referenced this issue Oct 13, 2020
@AdmiringWorm
(chocolatey-communityGH-30) Move code for extracting meta data to its…
cebbf8b 
… own function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

(GH-30) Add ability to compare meta information of found binaries AdmiringWorm/chocolatey-diff
2 participants
@mkevenaar @AdmiringWorm