Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation rule to disallow icon URL using GitHub raw links #28

Open
2 tasks done
TheCakeIsNaOH opened this issue Jan 18, 2024 · 1 comment
Open
2 tasks done

Add validation rule to disallow icon URL using GitHub raw links #28

TheCakeIsNaOH opened this issue Jan 18, 2024 · 1 comment
Labels
1 - Ready Issue is accepted, milestone added and are ready to be worked on Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.2.0

Comments

@TheCakeIsNaOH
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

It would be good to add rules for iconUrl validation. These should include a rule that github raw is not allowed to be used, and a rule that rawgit is not allowed as it has shut down.

Describe The Solution. Why is it needed?

Lots of packages get pushed to CCR with github raw and with rawgit links.

Additional Context

No response

Related Issues
@AdmiringWorm AdmiringWorm added Improvement Issues that enhances existing functionality, or adds new features 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Jan 19, 2024
@AdmiringWorm
Copy link
Member

AdmiringWorm commented Jan 19, 2024 •
edited
Loading

Seeing as this is a new rule, and it runs on the client side. This should probably be implemented as a requirement in this case.

@AdmiringWorm AdmiringWorm changed the title Add iconUrl host validation Add validation rule to disallow icon URL using GitHub raw links Jan 19, 2024
@AdmiringWorm AdmiringWorm added this to the 0.2.0 milestone Jan 19, 2024
@AdmiringWorm AdmiringWorm added 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint and removed 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Jan 19, 2024
@AdmiringWorm AdmiringWorm added 1 - Ready Issue is accepted, milestone added and are ready to be worked on and removed 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - Ready Issue is accepted, milestone added and are ready to be worked on Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@AdmiringWorm @TheCakeIsNaOH