Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metapackage example should use a locked [version] #69

Open
2 tasks done
kilobyte1024 opened this issue Jul 24, 2024 · 0 comments
Open
2 tasks done

Metapackage example should use a locked [version] #69

kilobyte1024 opened this issue Jul 24, 2024 · 0 comments

Comments

@kilobyte1024
Copy link

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

When submitting a chocolatey package, I recently received feedback that I needed to lock the metapackage to the exact version of the installer package. However this update was made by the stock installer.

This package still does not seem to have the expected dependency (at least in my expectations).

It currently has a dependency of (≥ 1.0.9046) when I would expect it to have a dependency of (= 1.0.9154).

current: <dependency id="discord.install" version="1.0.9046" />
suggested: <dependency id="discord.install" version="[1.0.9154]" />

The square bracket format seems like a more reasonable default. Can we please update the example templates for au_SearchReplace to include these square brackets?

Describe The Solution. Why is it needed?

This solution will add square brackets around the nuspec dependency definition when au_SearchReplace runs on the installer package. This will lock the metapackage to load the specific installer package version, not a ≥ range (the current default). Having this in the example will hopefully help avoid others who are new to Chocolatey development from running into this feedback pertaining to the template/example.

For more information on what the square brackets du, see "References in .nuspec files" in this doc: https://learn.microsoft.com/en-us/nuget/concepts/package-versioning?tabs=semver20sort#version-ranges

Additional Context

No response

Related Issues

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant