Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the canonical or og:url URL as the object's id #37

Open
davidbarratt opened this issue Aug 17, 2020 · 1 comment
Open

Use the canonical or og:url URL as the object's id #37

davidbarratt opened this issue Aug 17, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@davidbarratt
Copy link
Member

davidbarratt commented Aug 17, 2020 •
edited
Loading

web/utils/response/data-html.js

Line 89 in 60bb2d7

// @TODO Get the "canonical" url

The canonical or og:url URL should be used as the object's id and should be used for deduping purposes.
@davidbarratt davidbarratt added the bug Something isn't working label Aug 17, 2020
@davidbarratt davidbarratt changed the title Use the canonical URL as the object's id Use the canonical or og:url URL as the object's id Aug 17, 2020
@davidbarratt
Copy link
Member Author

I think the "id" from the feed should take precidence over the canonical url. It seems like the id is typically unique, but the canonical might be the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidbarratt