Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename autoUpdater to invokeUpdateIfNeeded #35

Open
davidbarratt opened this issue Aug 17, 2020 · 0 comments
Open

Rename autoUpdater to invokeUpdateIfNeeded #35

davidbarratt opened this issue Aug 17, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@davidbarratt
Copy link
Member

davidbarratt commented Aug 17, 2020 •
edited
Loading

This seems odd to be named this:

web/pages/_app.js

Line 122 in 670c8ed

const autoUpdater = useCallback(() => {

I think it should be renamed to something like invokeUpdateIfNeeded to make it more clear what it is doing and perhaps the context can be UpdateInvoker
@davidbarratt davidbarratt added bug Something isn't working good first issue Good for newcomers labels Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidbarratt