Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test with podman #68

Open
snprajwal opened this issue Jun 12, 2023 · 3 comments
Open

Add integration test with podman #68

snprajwal opened this issue Jun 12, 2023 · 3 comments

Comments

@snprajwal
Copy link
Member

snprajwal commented Jun 12, 2023

Currently, we only run tests with BATS. This does not let us test changes in real world scenarios with containers. An integration test where a container is checkpointed and then the archive used for testing is much more robust and bulletproof.

@rst0git
Copy link
Member

rst0git commented Jun 13, 2023

It might be good to have integration tests with both CRI-O and Podman.

@snprajwal
Copy link
Member Author

snprajwal commented Jun 14, 2023

One clarification for this - since the podman test I'm writing uses looper and the existing test uses piggie, would it make sense to have two separate BATS file for each of these tests? If the output differs, we can change it accordingly in the relevant file. Currently, the same test file works for both checkpoints, but I don't think that will stay the same as we add more features/ tests in the future.

@snprajwal
Copy link
Member Author

One clarification for this - since the podman test I'm writing uses looper and the existing test uses piggie, would it make sense to have two separate BATS file for each of these tests? If the output differs, we can change it accordingly in the relevant file. Currently, the same test file works for both checkpoints, but I don't think that will stay the same as we add more features/ tests in the future.

@rst0git @adrianreber what do you think of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants