Fix: Handle all valid ST characters #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no OSC spec, but it appears that most emulators accept
0x1B 0x5C
as anST
character, with0x07
and0x9C
as alternatives with a bit less support.This PR updates the regular expression to match all three of
0x1b 0x5C
,0x07
, and0x9C
as an ST character, and updates the test file accordingly.Choices I made, any of which I'm happy to change if you prefer:
Closes #56