Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_a is deprected on PHP 5.2.x #7

Open
robneu opened this issue Oct 1, 2015 · 2 comments
Open

is_a is deprected on PHP 5.2.x #7

robneu opened this issue Oct 1, 2015 · 2 comments

Comments

@robneu
Copy link

robneu commented Oct 1, 2015

Due to some ridiculousness in the PHP version history, the is_a function is deprecated from 5.0 until 5.3 when they un-deprecated it. 😕

Thanks to this, users still on PHP 5.2x would trigger some warnings when running the updater. It also looks like instanceof is a little better on performance anyway, so it's probably worth swapping out.

PR inbound.
@robneu robneu mentioned this issue Oct 1, 2015
Closed
@johnbillion
Copy link
Contributor

Does External Update API even work on PHP 5.2? I've never tested it.

@robneu
Copy link
Author

robneu commented Oct 6, 2015

It does. Well, at least I'm pretty sure it does.... I'm using a slightly modified fork of it for some internal stuff at WP Site Care and some of our customers are (sadly) still on 5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnbillion @robneu