Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match signature of SpikeGLXRecordingInterface interface to SpikeGLXRecordingExtractor extractor #978

Open
h-mayorquin opened this issue Aug 2, 2024 · 0 comments
Open

Match signature of SpikeGLXRecordingInterface interface to SpikeGLXRecordingExtractor extractor #978

h-mayorquin opened this issue Aug 2, 2024 · 0 comments
Labels
data interfaces spikeinterface

Comments

@h-mayorquin
Copy link
Collaborator

SpikeGLXRecordingInterface takes a file_path as an input and uses it to determine the stream whereas SpikeGLXRecordingExtractor takes a folder as input and uses the stream to determine the file.

I think we are kind of duplicating efforts here and it feels to me that we should strieve to keep the interafce between the two libraries consistent. Any downsides of moving in this direction that I am not seeing?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data interfaces spikeinterface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@h-mayorquin