Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected consumption of env.yml.tmp during mvn package tests #75

Open
Rillke opened this issue Mar 26, 2018 · 3 comments
Open

Unexpected consumption of env.yml.tmp during mvn package tests #75

Rillke opened this issue Mar 26, 2018 · 3 comments

Comments

@Rillke
Copy link

Rillke commented Mar 26, 2018

When running mvn package, env.yml.tmp and server.yml.tmp are consumed instead of those without .tpl extension. This is undocumented and unexpted. Tests fail if no mongodb is running on localhost and on the other hand, if a mongodb is running at localhost it is accessed during mvn package, which might be unwanted or unexpected.

The official deployment manual says:

Copy the included configuration env templates for both the server and UI repos

and later

Package the application using Maven

However, it fails to mention that hard coded test.

@abyrd
Copy link

abyrd commented Apr 3, 2018

Hello, I believe these tests (and the build as a whole) are only really configured for our continuous integration environment. That's the only way the project is ever built in our usual process. Point taken though, if people are going to be building this in other places we need to make it clear that the tests connect to the DB and adjust the config files so that's even possible. We might somehow put those database-backed tests into an optional profile.

@abyrd
Copy link

abyrd commented Apr 3, 2018

@landonreed do we have any necessary tests that need to connect to either database? Why does this particular test use one configuration file that does not exist (server.yml) and another configuration file that doesn't seem to provide enough information to connect to Mongo? How does it work within the CI environment?

@abyrd
Copy link

abyrd commented Apr 3, 2018

Ah, I see we've got a line in the Travis config that does cp configurations/default/server.yml.tmp configurations/default/server.yml. I would say the build and tests should run out of the box with as little prep as possible. Maybe we should have a configurations/testing containing the appropriate configuration files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants