Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a chart for a cartesi-dapp CRD #33

Open
endersonmaia opened this issue Aug 10, 2023 · 4 comments
Open

Create a chart for a cartesi-dapp CRD #33

endersonmaia opened this issue Aug 10, 2023 · 4 comments

Comments

@endersonmaia
Copy link
Collaborator

endersonmaia commented Aug 10, 2023

sunodo plans to start working on a kubernetes controller that would watch the blockchain and deploy a rollups-validator-node for each dapp.

To simplify the interface between sunodo and a kubernetes cluster, Cartesi could provide a CRD/CartesiDApp that holds all the information necessary to start a new node for that dapp.

One would need to run a cartesi-node-operator that looks for new CartesiDApp resources and deploys the node, using helm and the current rollups-validator-node helm chart.

Note: The cartesi-node-operator doesn't exist yet.

@tuler
Copy link
Member

tuler commented Aug 10, 2023

I would not say a CRD for CartesiNode. It's a CRD for a CartesiDApp.
If a DApp needs a node or not, that's the decision of the operator.

@endersonmaia endersonmaia changed the title Create a chat for a cartesi-node CRD Create a chat for a cartesi-dapp CRD Aug 10, 2023
@omidasadpour
Copy link
Contributor

How should the operator deploy in the K8s ? Via helm ?

@endersonmaia
Copy link
Collaborator Author

https://helm.sh/docs/chart_best_practices/custom_resource_definitions/

Should we create a CRD chart and reuse it on a cartesi-node-operator chart?

Or should we have crds to be installed when installing the cartesi-node-operator chart?

I'd like your opinion on that @oap75 @tuler


I personally like the idea of having the CRDs on a independent chart, so that others can use the CRDs with other possible operator implementation.

The cartesi-node-operator should use the cartesi-dapp-crd chart as a dependency.

Also, the lifecycle of development of both could be easier if they're separated in different charts, I think.

@omidasadpour
Copy link
Contributor

Should we create a CRD chart and reuse it on a cartesi-node-operator chart?

Yes, I think this is the best one to pick.

Like what karpenter does : https://gallery.ecr.aws/karpenter/karpenter-crd

@endersonmaia endersonmaia changed the title Create a chat for a cartesi-dapp CRD Create a chart for a cartesi-dapp CRD Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants