Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2 section duplicated anchors #598

Open
froggleston opened this issue Jul 31, 2024 · 0 comments · Fixed by #600
Open

H2 section duplicated anchors #598

froggleston opened this issue Jul 31, 2024 · 0 comments · Fixed by #600
Labels
bug Something isn't working

Comments

@froggleston
Copy link
Contributor

froggleston commented Jul 31, 2024

The recent update to pkgdown (from 2.0.9 to 2.1.0) has resulted in a feature that we cannot get around without removing our core translation feature for section headings (h2) from the Workbench: r-lib/pkgdown#2737

Note, this is not the same as the CrowdIn translations but the translation of lesson specific sections, e.g. “Key Points”, etc

Until pkgdown developers add support for choosing which elements to apply anchors to, or us removing the translation support for h2 anchors, or perhaps moving these anchor translations into pkgdown (which would split our translation code), our tests will fail. Lessons continue to build successfully but have the rather confusing double link icon for each H2 section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant