Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child files not processed for validation #68

Open
jcolomb opened this issue Sep 4, 2023 · 2 comments · May be fixed by carpentries-incubator/managing-computational-projects#119
Open

child files not processed for validation #68

jcolomb opened this issue Sep 4, 2023 · 2 comments · May be fixed by carpentries-incubator/managing-computational-projects#119
Labels
bug Something isn't working {pegboard} validator R package

Comments

@jcolomb
Copy link

jcolomb commented Sep 4, 2023

::::::::instructor is the right way to get instructor notes

:::::::: Instructor (Capital I) does not gives an error, but the text is then not in a box and not visible in the /instructornote.html view. It is still only visible in the "instructor view" of the course, but as normal text.

Is there a way to create error or warnings for the second div ?
@zkamvar zkamvar added the {pegboard} validator R package label Sep 4, 2023
@zkamvar zkamvar mentioned this issue Sep 4, 2023
Closed
@zkamvar
Copy link
Contributor

zkamvar commented Sep 4, 2023

Thank you for reporting this, @jcolomb! This is a feature for lessons, but in the context of child files, {pegboard} does not actually take them into account, which is clearly a bug!

I've opened carpentries/pegboard#135 to track the issue. I will report back here when I've created a fix.

@zkamvar zkamvar added the bug Something isn't working label Sep 4, 2023
@zkamvar zkamvar changed the title instructor vs Instructor Fenced Divs child files not processed for validation Sep 4, 2023
@zkamvar zkamvar mentioned this issue Sep 8, 2023
Merged
zkamvar added a commit to carpentries-incubator/managing-computational-projects that referenced this issue Sep 15, 2023
@zkamvar
fix fences in 12-analysis.md
a0f3d05 
I am testing out carpentries/sandpaper#513 and carpentries/pegboard#137 to help with validation and building, which will fix carpentries/workbench#68

There was an error because the div fences were too close to the text, so I added spaces.
@zkamvar zkamvar linked a pull request Sep 15, 2023 that will close this issue
Open
@zkamvar
Copy link
Contributor

zkamvar commented Sep 26, 2023

I am planning to release the fix for this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working {pegboard} validator R package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix fences in 12-analysis.md carpentries-incubator/managing-computational-projects
2 participants
@jcolomb @zkamvar