Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed formatting of title when not blended with body #914

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jul 22, 2023

Description:

Related issue (if applicable): #913

A bug was detected causing the title of some messages to be escaped with HTML characters in circumstances when it should.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@913-title-html-characters

# Create ourselves a config file that causes he clash:
cat < _EOF >> apprise-913-title-html-characters.yml
urls:
  - tgram://{{ token }}/{{ chat }}/
  - mailtos://{{ username }}:{{ password }}@{{ domain }}:{{ port }}?smtp={{ smtp_host }}&from=Paperless<{{ smtp_email }}>&to={{ email }}
_EOF

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" -c  apprise-913-title-html-characters.yml

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (01f757d) 99.98% compared to head (6079fd7) 99.98%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #914   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         122      122           
  Lines       16199    16200    +1     
  Branches     3303     3303           
=======================================
+ Hits        16197    16198    +1     
  Misses          1        1           
  Partials        1        1           
Impacted Files Coverage Δ
apprise/Apprise.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@caronc caronc merged commit 768b384 into master Jul 22, 2023
14 checks passed
@caronc caronc deleted the 913-title-html-characters branch August 14, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants