Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(leftnavtree): style updates #1520

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(leftnavtree): style updates #1520

wants to merge 7 commits into from

Conversation

szinta
Copy link
Contributor

@szinta szinta commented Sep 24, 2024 •
edited
Loading

Closes #1507

Fixes style issues mentioned in #1507

Now following the below Color codes for dark and light themes

Dark theme:

Nav background:  #161616
Nav right Border: #393939;
Divider color: #393939

Light theme:

Nav background:  #ffffff
Nav right Border: #e0e0e0;
Divider color: #c6c6c6

@szinta szinta requested review from eng618 and a team as code owners September 24, 2024 05:31
@szinta szinta requested review from tay1orjones and annawen1 and removed request for a team September 24, 2024 05:31
@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 3:46am

@szinta szinta changed the title fix(lefttreenav): style updates fix(leftnavtree): style updates Sep 24, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 24, 2024 •
edited
Loading

✅ Deploy Preview for gatsby-theme-carbon ready!

Name Link
🔨 Latest commit 8a96e62
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/66fb6fecd6cc3c0008b8f115
😎 Deploy Preview https://deploy-preview-1520--gatsby-theme-carbon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alisonjoseph
alisonjoseph reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM other than the question about the extra nav divider

packages/example/src/data/nav-items.yaml Outdated Show resolved Hide resolved
elycheea
elycheea approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elycheea elycheea elycheea approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@eng618 eng618 Awaiting requested review from eng618 eng618 is a code owner

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nav divider is wrong color in dark theme
4 participants
@szinta @elycheea @alisonjoseph @sintaibm