Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav divider is wrong color in dark theme #1507

Open
4 tasks
alisonjoseph opened this issue Sep 5, 2024 · 1 comment · May be fixed by #1520
Open
4 tasks

Nav divider is wrong color in dark theme #1507

alisonjoseph opened this issue Sep 5, 2024 · 1 comment · May be fixed by #1520
Assignees
Labels
role: dev 🤖 severity: 3 Affects minor functionality, has a workaround type: bug 🐛

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented Sep 5, 2024

Screenshot 2024-09-05 at 7 36 53 AM

Should be gray 20 I believe (you can see Carbon v10 website for correct color)

Also in light theme, we should use white background for the left nav for contrast with the gray-10 content background.

Tasks

@elycheea
Copy link
Contributor

elycheea commented Sep 6, 2024

@alisonjoseph We caught a few more style fixes when we implemented on our end1. I can update this issue to include those as well and close carbon-design-system/carbon-for-products-website#101 in favor of this issue for tracking.

Footnotes

  1. Overrides from PR carbon-design-system/carbon-for-products-webiste#98

@elycheea elycheea added severity: 3 Affects minor functionality, has a workaround role: dev 🤖 labels Sep 6, 2024
@szinta szinta linked a pull request Sep 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: dev 🤖 severity: 3 Affects minor functionality, has a workaround type: bug 🐛
Projects
Status: Needs review 👋
Development

Successfully merging a pull request may close this issue.

3 participants