-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: caption spacing inside tab #1523
base: main
Are you sure you want to change the base?
fix: caption spacing inside tab #1523
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for gatsby-theme-carbon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kritvi-bhatia17 the white background is coming from the Tabs component, not the image. The caption is within the tab, so it will appear on the white background. The only thing this PR is doing is adding the correct spacing above the caption that was missing when it was used inside of the Tabs component. Do we need to adjust the bottom spacing also? The default bottom spacing inside gatsby tabs is larger. |
Oh, got it, Alison. Thanks a lot for the detailed explanation! |
Hi @alisonjoseph, I discussed with the team, and it seems a bit inconsistent with other images where the caption appears below the image. |
Closes #1493
Changelog
Testing
Check captions on Tabs and Captions page. Should have 1rem top margin.