Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caption spacing inside tab #1523

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Sep 30, 2024

Closes #1493

Changelog

  • add correct top margin above captions

Testing

Check captions on Tabs and Captions page. Should have 1rem top margin.

@alisonjoseph alisonjoseph requested review from eng618 and a team as code owners September 30, 2024 18:23
@alisonjoseph alisonjoseph requested review from kennylam and ariellalgilmore and removed request for a team September 30, 2024 18:23
Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 6:28pm

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for gatsby-theme-carbon ready!

Name Link
🔨 Latest commit 8c75cb9
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/66faed011970710008a36589
😎 Deploy Preview https://deploy-preview-1523--gatsby-theme-carbon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alison!
Will the caption appear within the image, meaning will the caption have the same white background as the image? 🤔

image

(This is what I’m looking at 👇🏻, I hope that’s correct)

image

@alisonjoseph
Copy link
Member Author

alisonjoseph commented Sep 30, 2024

@Kritvi-bhatia17 the white background is coming from the Tabs component, not the image. The caption is within the tab, so it will appear on the white background. The only thing this PR is doing is adding the correct spacing above the caption that was missing when it was used inside of the Tabs component.

Screenshot 2024-09-30 at 4 20 10 PM Screenshot 2024-09-30 at 4 23 26 PM

Do we need to adjust the bottom spacing also? The default bottom spacing inside gatsby tabs is larger.
Screenshot 2024-09-30 at 4 22 15 PM

@Kritvi-bhatia17
Copy link

Oh, got it, Alison. Thanks a lot for the detailed explanation!
In that case, I’ll just confirm with the other designers as well and will get back to you.

@Kritvi-bhatia17
Copy link

Hi @alisonjoseph, I discussed with the team, and it seems a bit inconsistent with other images where the caption appears below the image.
Initially, I thought adding captions for the tab images would improve consistency, but given the current solution, it might look a bit odd and cause confusion, especially with images (shown below) that already include text. It could become unclear which is the caption and which is part of the artwork.
Sorry about this and thanks for working on the issue! I just wanted to explore the possibility of adding captions for the tab images below them.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Image caption] Add captions under each tab image
3 participants