Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby v5 ☂️ #1324

Closed
8 tasks done
eng618 opened this issue Aug 4, 2023 · 4 comments
Closed
8 tasks done

Gatsby v5 ☂️ #1324

eng618 opened this issue Aug 4, 2023 · 4 comments
Labels
Feature request planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖
Milestone

Comments

@eng618
Copy link
Collaborator

eng618 commented Aug 4, 2023

Summary

Upgrade the theme to use Gatsby v5

Justification

Keeping up with technology changes, and security compliance.

Tasks

  1. role: dev 🤖
    alisonjoseph
  2. role: dev 🤖
    alisonjoseph
  3. role: dev 🤖
    alisonjoseph
  4. role: dev 🤖
    alisonjoseph
  5. role: dev 🤖
    muditjuneja
  6. role: dev 🤖
    alisonjoseph
  7. role: dev 🤖
    alisonjoseph
  8. role: dev 🤖
    alisonjoseph
@eng618 eng618 self-assigned this Aug 4, 2023
@eng618 eng618 mentioned this issue Aug 4, 2023
@eng618
Copy link
Collaborator Author

eng618 commented Aug 4, 2023

Most of this work is done on the next branch.

The remaining pieces are as follows:

@eng618
Copy link
Collaborator Author

eng618 commented Sep 1, 2023

For a little more context. The defaultLayouts node for the gatsby-plugin-mdx plugin is no longer a valid configuration. So, the below templates for Default.js and Homepage.js need to be converted into components that can be injected into every page. There are a few ways to do this, as outlined in the linked docs above.

{
  resolve: `gatsby-plugin-mdx`,
  options: {
    extensions: mdxExtensions,
    gatsbyRemarkPlugins: [
      ...defaultRemarkPlugins,
      ...gatsbyRemarkPlugins,
    ],
    remarkPlugins,
    defaultLayouts: {
      default: require.resolve('./src/templates/Default.js'),
      home: require.resolve('./src/templates/Homepage.js'),
      ...extraLayouts,
    },
  },
},

@muditjuneja
Copy link
Contributor

muditjuneja commented Feb 7, 2024

More observed issues in next -

  • Tables listing the component props is not being rendered correctly
  • Code blocks having more than 8 lines are not being rendered correctly
Screenshot 2024-02-08 at 2 06 16 AM Screenshot 2024-02-08 at 2 06 32 AM

@alisonjoseph alisonjoseph added the planning: umbrella Umbrella issues, surfaced in Projects views label Feb 28, 2024
@alisonjoseph alisonjoseph changed the title Gatsby v5 Gatsby v5 ☂️ Feb 28, 2024
@alisonjoseph alisonjoseph pinned this issue Feb 28, 2024
@alisonjoseph
Copy link
Member

@eng618 was looking at the webpack warnings and I think it may be something we can ignore. https://robertmarshall.dev/blog/fix-warn-chunk-commons-mini-css-extract-plugin-error-in-gatsby-js/

@sstrubberg sstrubberg added this to the 2024 Q2 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖
Projects
Archived in project
Development

No branches or pull requests

4 participants