Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web impl EAN-13 and other formats not working except QR #267

Open
muuvmuuv opened this issue Jun 30, 2023 · 1 comment
Open

Web impl EAN-13 and other formats not working except QR #267

muuvmuuv opened this issue Jun 30, 2023 · 1 comment

Comments

@muuvmuuv
Copy link

Describe the bug

We've used the Web PWA version a long time now, QR and other formats work well, but EAN-13 does never return any result. The demo from ZXing 1D instead works pretty well and fast, any idea?

https://zxing-js.github.io/library/examples/multi-camera/

To Reproduce
Steps to reproduce the behavior:

  1. Try any 1D EAN-13

Expected behavior

Should work like the ZXing web demo.

Screenshots
If applicable, add screenshots to help explain your problem.

Version
[e.g. v1.0.0]
^3

Desktop (please complete the following information):

  • OS: [e.g. iOS] browser
  • Browser [e.g. chrome, safari] chrome
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@muuvmuuv
Copy link
Author

Found out web impl just needs two adjustments:

https://github.com/capacitor-community/barcode-scanner/blob/main/src/web.ts#L50

Must push format!

https://github.com/capacitor-community/barcode-scanner/blob/main/src/web.ts#L168

Use BrowserMultiFormatReader...

Now all formats are supported by ZXing! 🚀

@muuvmuuv muuvmuuv changed the title Web impl EAN-13 not working Web impl EAN-13 and other formats not working except QR Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant