From 7595811c6f5ebc75e981490f90fd7654f656be93 Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 16 Feb 2024 15:23:32 +0100 Subject: [PATCH 1/2] fix: Don't crash if canberra-gtk-play doesn't exist --- .../lib/src/services/sound_service.dart | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/ubuntu_provision/lib/src/services/sound_service.dart b/packages/ubuntu_provision/lib/src/services/sound_service.dart index 930a66e29..df543460a 100644 --- a/packages/ubuntu_provision/lib/src/services/sound_service.dart +++ b/packages/ubuntu_provision/lib/src/services/sound_service.dart @@ -1,7 +1,18 @@ import 'dart:io'; +import 'package:ubuntu_logger/ubuntu_logger.dart'; + +final _log = Logger('sound_service'); + +/// A service for playing sounds. class SoundService { Future play(String id) async { - await Process.run('canberra-gtk-play', ['--id=$id']); + try { + await Process.run('canberra-gtk-play', ['--id=$id']); + } on ProcessException catch (e) { + _log.error( + 'Error playing sound with id: $id (most likely missing canberra-gtk-play)', + ); + } } } From 8feccc05504ba258467f6d77b96730f0aed0b13a Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 16 Feb 2024 15:47:01 +0100 Subject: [PATCH 2/2] Remove e reference --- packages/ubuntu_provision/lib/src/services/sound_service.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ubuntu_provision/lib/src/services/sound_service.dart b/packages/ubuntu_provision/lib/src/services/sound_service.dart index df543460a..278a518eb 100644 --- a/packages/ubuntu_provision/lib/src/services/sound_service.dart +++ b/packages/ubuntu_provision/lib/src/services/sound_service.dart @@ -9,7 +9,7 @@ class SoundService { Future play(String id) async { try { await Process.run('canberra-gtk-play', ['--id=$id']); - } on ProcessException catch (e) { + } on ProcessException catch (_) { _log.error( 'Error playing sound with id: $id (most likely missing canberra-gtk-play)', );