Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The demo crashes in caikit v0.15 #22

Open
itaijj opened this issue Aug 9, 2023 · 1 comment
Open

The demo crashes in caikit v0.15 #22

itaijj opened this issue Aug 9, 2023 · 1 comment

Comments

@itaijj
Copy link

itaijj commented Aug 9, 2023

The hugging face demo is broken now and don't work with caikit v0.15 because of the change with RuntimeGRPCServer API change
with RuntimeGRPCServer( TypeError: __init__() got an unexpected keyword argument 'inference_service'
can you please fix it?

@markstur
Copy link
Collaborator

markstur commented Aug 9, 2023

Thanks for reporting this.

It should have been clear that the demo app only works with what is specified in requirements.txt, but looking back at the README I am not seeing any specific call-out of the caikit prereq or other library prereqs. I think I decided that stating that the requirements are prerequisites was redundant and unnecessarily extra wordy. Does it make sense to say "You must have the required version of caikit (and the other requirements)" before the instruction to install requirements.txt? Pinned versions are used. Maybe a few extra words in the README would help others avoid this problem?

Otherwise caikit 0.x upgrades are always assumed to be breaking changes (as opposed to 0.x.y bumps). I added a new issue for the upgrade work #23. That's how we generally assign and close the regular maintenance updates vs "crash" bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants