Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename studies field to samples in virtual study data bean #11094

Open
forus opened this issue Oct 21, 2024 · 0 comments
Open

Rename studies field to samples in virtual study data bean #11094

forus opened this issue Oct 21, 2024 · 0 comments

Comments

@forus
Copy link
Contributor

forus commented Oct 21, 2024

The field name is not good. The field stores samples, not studies.

package org.cbioportal.web.parameter;

...

@JsonIgnoreProperties(ignoreUnknown = true)
public class VirtualStudyData implements Serializable {

...
    private Set<VirtualStudySamples> studies;

Ticket originates from:
#11040 (comment)

The fix should include migration scripts for VS that were created with the old field name already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@forus