Support drives other than C:\ on Windows #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited `filesystem.js` functions to support Windows drives - `getDirectoryContents` shows a list of Windows drives when requested `/` root path - Subsequent paths will be formatted as `/<drive letter>/<path>`. Eg. `/c/Users/neojp/Desktop/archive.bcup` - A new function `normalizeWindowsPath` will convert server request paths into resolved Windows paths `/c/Users/neojp/Desktop/archive.bcup` -> `c:\\Users\\neojp\\Desktop\\archive.bcup` Fixes buttercup#3
perry-mitchell
requested changes
Jul 16, 2019
There was a problem hiding this comment.
There's the unfortunate problem that users with existing archives will not have the drive letter saved in their current paths. To prevent breaking their configurations and having them to destroy and re-add them, could we make it so that paths without the drive letter default to /c/?
|
Good catch. Let me try that out. |
|
@neojp Have you had a chance to check on the request I made? If not I could try to tackle it.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited
filesystem.jsfunctions to support Windows drivesgetDirectoryContentsshows a list of Windows drives when requested/root path/<drive letter>/<path>. Eg./c/Users/neojp/Desktop/archive.bcupnormalizeWindowsPathwill convert server request paths into resolved Windows paths/c/Users/neojp/Desktop/archive.bcup->c:\\Users\\neojp\\Desktop\\archive.bcupFixes #3
Fixes buttercup/buttercup-desktop#708
Fixes buttercup/buttercup-browser-extension#206
Fixes buttercup/buttercup-browser-extension#232