Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

Flattened file does not respect dependency order #1

Open
julienrffr opened this issue Sep 8, 2021 · 4 comments
Open

Flattened file does not respect dependency order #1

julienrffr opened this issue Sep 8, 2021 · 4 comments

Comments

@julienrffr
Copy link

I'm testing Flattener via Remix IDE (https://remix.ethereum.org/).

I have a basic contract that import this:
import "@openzeppelin/contracts/token/ERC721/ERC721.sol"; import "@openzeppelin/contracts/token/ERC721/extensions/ERC721Enumerable.sol"; import "@openzeppelin/contracts/access/Ownable.sol";

But the flattened output file embeds dependencies in the wrong order.
This causes error while compiling on etherscan.

@julienrffr julienrffr changed the title Flattened file doe snot respect dependency order Flattened file does not respect dependency order Sep 8, 2021
@theprojectabot
Copy link

theprojectabot commented Sep 30, 2021

I also have encountered this same issue:

TypeError: Definition of base has to precede definition of derived contract
   --> myc:249:30:
    |
249 | abstract contract Ownable is Context {
    |                              ^^^^^^^

@bunsenstraat
Copy link
Owner

Good point!

@bunsenstraat
Copy link
Owner

could you test it with ipfs://QmTX5ktywUaHSiEzdxf91C5gpE2MShpD1KxNmCd3Dzy1pR in the local plugin tab of REMIX to see if this works for you? @theprojectabot

@ed0xe
Copy link

ed0xe commented Oct 13, 2021

could you test it with ipfs://QmTX5ktywUaHSiEzdxf91C5gpE2MShpD1KxNmCd3Dzy1pR in the local plugin tab of REMIX to see if this works for you? @theprojectabot

@bunsenstraat I confirm that this works

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants