CPP: modify package namespace to split on dot #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated protoc-gen-star to v2.0.4 @496ad1ac90a4 using: go get github.com/lyft/protoc-gen-star/v2@496ad1ac90a4 Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
|
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
elliotmjackson
changed the title
|
Hey @rodaine I see that this was reopened. |
|
Hey @adisuissa! Yes, if you'd like to update it go for it. We realized today this was probably closed in error, which is why it was reopened. Let me know if you need anything from me 😁 |
Signed-off-by: Adi Suissa-Peleg <[email protected]>
rodaine
approved these changes
Mar 15, 2024
|
Thanks again for the patch! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing C++ namespace to only use dot-notation splitting.
For example, a proto that is in a package:
my_projectwill use the same C++ namespace, avoiding the conversion tomy::projectas is done prior to this PR.Also updated protoc-gen-star to v2.0.4 @496ad1ac90a4 (ability to use
SplitOnDot) using:go get github.com/lyft/protoc-gen-star/v2@496ad1ac90a4Fixes #822