Cannot use map.keys.string.pattern and map.values.string.pattern rules together in a single annotation

[kyoungkwon]

When I use map.keys.string.pattern and map.values.string.pattern rules in a single annotation, I can't compile the generated code.
For example, I have the following message definition:

message Labels {
  map<string, string> label_map = 1
  [(validate.rules).map = { max_pairs: 128,
                            keys: {string: {min_len: 2, max_len:63, pattern: "^[a-z0-9A-Z._-]$"}},
                            values: {string: {min_len: 2, max_len:63, pattern: "^[a-z0-9A-Z._-]$"}}}];
}

Then the generated code have duplicate variables with the same name like this:

var _Labels_LabelMap_Pattern = regexp.MustCompile("^[a-z0-9A-Z._-]$")

var _Labels_LabelMap_Pattern = regexp.MustCompile("^[a-z0-9A-Z._-]$")

Which causes the build to fail with the following error:

pkg/proto/v1alpha/examples/labels.pb.validate.go:142:5: _Labels_LabelMap_Pattern redeclared in this block
        previous declaration at pkg/proto/v1alpha/examples/labels.pb.validate.go:140:5

[rodaine]

Thanks for the report! This is indeed a bug.

[gnagel]

Ditto to this same issue, this is happening to me with the latest version v0.6.12/validate/validate.proto

[alexandreschoenwitz]

What is the reason was this closed as completed? The Bug is still there or not?

[elliotmjackson]

Just a quick heads up – we've rolled out protovalidate, and it's free from the bug you mentioned here. Feel free to check it out and enjoy a smoother experience!

[chrispine]

As explained in the README, this project is in maintenance mode. We recommend upgrading to protovalidate.

I'm going to go ahead and close this issue, but feel free to open one against protovalidate if needed. Thanks!