Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix the failure of goreleaser #1146

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

suzuki-shunsuke
Copy link
Contributor

The release workflow failed at v1.1.0.

https://github.com/bufbuild/protoc-gen-validate/releases/tag/v1.1.0

https://github.com/bufbuild/protoc-gen-validate/actions/runs/10252222901/job/28362117064

/opt/hostedtoolcache/goreleaser-action/2.1.0/x64/goreleaser release --rm-dist
  ⨯ command failed                                   error=unknown flag: --rm-dist
Error: The process '/opt/hostedtoolcache/goreleaser-action/2.1.0/x64/goreleaser' failed with exit code 1

--rm-dist was deprecated.

https://goreleaser.com/deprecations/#-rm-dist

Furthermore, we need to add version: 2.

$ goreleaser check
  • only configurations files on  version: 2  are supported, yours is  version: 0 , please update your configuration

The release workflow failed at v1.1.0.

https://github.com/bufbuild/protoc-gen-validate/releases/tag/v1.1.0

https://github.com/bufbuild/protoc-gen-validate/actions/runs/10252222901/job/28362117064

```
/opt/hostedtoolcache/goreleaser-action/2.1.0/x64/goreleaser release --rm-dist
  ⨯ command failed                                   error=unknown flag: --rm-dist
Error: The process '/opt/hostedtoolcache/goreleaser-action/2.1.0/x64/goreleaser' failed with exit code 1
```

--rm-dist was deprecated.

https://goreleaser.com/deprecations/#-rm-dist

Furthermore, we need to add `version: 2`.

```console
$ goreleaser check
  • only configurations files on  version: 2  are supported, yours is  version: 0 , please update your configuration
```
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2024

CLA assistant check
All committers have signed the CLA.

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review August 5, 2024 21:46
@rodaine rodaine changed the title ci: fix the failure of goreleaser CI: fix the failure of goreleaser Aug 5, 2024
@rodaine rodaine merged commit e4899f2 into bufbuild:main Aug 12, 2024
4 checks passed
@rodaine
Copy link
Member

rodaine commented Aug 12, 2024

Thanks @suzuki-shunsuke!

@suzuki-shunsuke suzuki-shunsuke deleted the ci-fix-goreleaser-v2 branch August 12, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants