Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If input is pure punctuation or numbers, pass it through unmodified #419

Open
kpu opened this issue Jun 5, 2022 · 1 comment
Open

If input is pure punctuation or numbers, pass it through unmodified #419

kpu opened this issue Jun 5, 2022 · 1 comment

Comments

@kpu
Copy link
Member

kpu commented Jun 5, 2022

We're getting a lot of complaints about misc punctuation turning into weird stuff. The problem is we clean out training data that's pure punctuation.

Example: https://techcrunch.com/2022/06/02/mozilla-brings-free-offline-translation-to-firefox/ complains about |

I realize this is the start of a larger component that handles exceptions for translation.
@kpu kpu mentioned this issue Jun 5, 2022
Closed
@kpu kpu changed the title If input is pure punctuation, pass it through unmodified If input is pure punctuation or numbers, pass it through unmodified Jun 5, 2022
@Elaborendum
Copy link

Is mozilla/firefox-translations#365 also related to this?

@marco-c marco-c mentioned this issue Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kpu @Elaborendum